Use https scheme to request to API endpoint - #151
Merged
Conversation
Contributor
Author
|
The reason CI was failed because CircleCI was not available back then. |
Member
|
ok. It's a patch for an old version. |
xerial
approved these changes
Jun 2, 2020
trung-huynh
force-pushed
the
use-https-for-api
branch
from
June 2, 2020 08:49
96048fe to
f21f652
Compare
Member
|
@trung-huynh Could you help me fixing javadoc as well? With Java8 or 11, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version
v0.2.14.3is using HTTP to request to API endpoint. HTTP is unsecure and should be replaced by HTTPS.The PR only updates the scheme from HTTP to HTTPS and should not impact to current stable version.