refactor: re-use recalculate_wanted_pieces logic in wishlist constructor
#7946
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
added
scope:core
type:refactor
tearfur
force-pushed
the
reuse-recalculate
branch
2 times, most recently
from
9c16ae4 to
22efd58
Compare
tearfur
force-pushed
the
reuse-recalculate
branch
from
22efd58 to
ebabcff
Compare
ckerr
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to fill the candidate vector in the Wishlist constructor is just a simplified version of
recalculate_wanted_pieces(), so directly re-use the function in the constructor.Note
This PR is not correct without #7945, so that PR should be merged first.Edit: Merged.