fix: handle unaligned torrents in wishlist #7944
Open
+668
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
force-pushed
the
wishlist-unaligned
branch
from
cbe6192 to
e911ed1
Compare
tearfur
force-pushed
the
wishlist-unaligned
branch
from
e911ed1 to
9dffc95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7919
Instead of trying to handle unaligned torrents in mediator code, handle them in the wishlist itself. This allows us to handle more edge cases are write tests for them.
Notes: Fixed
4.1.0-beta.1bug where torrents with unaligned piece and block boundaries gets stuck at 99%.