Skip to content

Fix. Mac GUI. Incorrect filter selected when hiding the Filter Bar and then showing it again #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beyondcompute wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix. Mac GUI. Incorrect filter selected when hiding the Filter Bar and then showing it again #7844

beyondcompute wants to merge 2 commits into from

Conversation

@beyondcompute
Copy link

@beyondcompute beyondcompute commented Nov 22, 2025 •
edited
Loading

How to reproduce the issue:

  1. Show the Filter Bar (⌘+F)
  2. Select any filter that is not “All”, for example “Active”
  3. Hide the Filter Bar. This will switch the app to showing all downloads again
  4. Show the Filter Bar. The app will keep showing all downloads but the previous filter (“Active”) will be highlighted. After that if you click on another filter, say “All” two filters in the Filter Bar will be highlighted. You need to click the third time (on some other filter), so that the filter is properly activated and highlighted in the Filter Bar.

A screenshot showing an inconsistent state of the UI after hiding and showing the filter bar again:

Screenshot

The fix consists of explicitly setting the filter to “All” before hiding the Filter Bar. Also as the updateUI parameter ends up being YES in all cases now, it has been removed in a separate commit.

FYI. The updateUI parameter was added to FilterBarController#reset here: 3479946

Notes: Fix the highlighting of filter buttons when hiding and then showing the Filter Bar again

⚠️ This is an AI-assisted work. 🤖

@beyondcompute
Set filter to "All" when hiding the filter bar
4f8251d 
Otherwise the filters will reset but the tab, for example "Downloading" will still be selected
when the filter is shown again. We want to keep the tabs synchronized with filters state.
@beyondcompute
Remove unused BOOL parameter (the method is always called with YES)
bb14b4a
@ckerr
Copy link
Member

ckerr commented Nov 22, 2025

CC macOS @transmission/contributors

@ckerr ckerr added the needs notes PR title needs a one-sentence paragraph starting with 'Notes:' to summarize for the release notes label Nov 22, 2025
@nevack
Copy link
Member

nevack commented Nov 23, 2025

Assigning to myself, as I have recently touched code around in #7840

@nevack nevack self-assigned this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nevack nevack

Labels

needs code review needs notes PR title needs a one-sentence paragraph starting with 'Notes:' to summarize for the release notes scope:mac type:fix A bug fix

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beyondcompute @ckerr @nevack