Skip to content

macOS 26: set icons on most menu items #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
livings124 merged 3 commits into from
Nov 9, 2025
Merged

macOS 26: set icons on most menu items #7787

livings124 merged 3 commits into from
Nov 9, 2025

Conversation

@livings124
Copy link
Member

@livings124 livings124 commented Nov 9, 2025

This is a first pass, and likely needs some adjustments and updated.

This also removes Select None, which does not seem to be in favor in Mac apps anymore.

@livings124
macOS 26: set icons on most menu items
1a59cf3 
This is a first pass, and likely needs some adjustments and updated.

This also removes Select None, which does not seem to be in favor in Mac apps anymore.
@livings124
Explicitly set the image on toolbar items' menu representation
6717b5f
@livings124
Icons for Info > Files context menu
19925b5
@livings124 livings124 merged commit b992327 into main Nov 9, 2025
27 checks passed
@livings124 livings124 deleted the menu-icons branch November 9, 2025 22:28
nevack
nevack reviewed Nov 9, 2025
View reviewed changes
Copy link
Member

@nevack nevack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to recheck all icons for their availability on supported deployment target

@nevack
Copy link
Member

nevack commented Nov 9, 2025

@livings124

  1. Please, open a tracking issue for all such post-Tahoe/Liquid Glass changes, so we can coordinate things. It is Updated app icon for Liquid Glass #7736, Update the macOS document icon to match the new app icon #7782 and macOS 26: set icons on most menu items #7787. I can create such issue myself, but please, I need your cooperation on this :)
  2. Was there any urgency in merging this without any code review? I found myself reviewing a PR that was already merged by the time I posted the review comments.

@livings124
Copy link
Member Author

livings124 commented Nov 9, 2025

Sorry about that. I'm so used to having to merge these without reviews that I pushed the button proactively. I won't do that in the future.

@livings124 livings124 mentioned this pull request Nov 9, 2025
Closed
@livings124
Copy link
Member Author

livings124 commented Nov 9, 2025

Opened:
#7788
#7789

@nevack
Copy link
Member

nevack commented Nov 9, 2025 •
edited
Loading

Thank you for creating the issue and for the clarification!

Also, why was "Select none" menu item removed?
https://github.com/transmission/transmission/pull/7787/files#diff-1f4e2711051d3415eda05a41930a714a4dda2feb7d8dcbeca0a292f653ddd968L706

@ckerr ckerr added scope:mac type:ui notes:none Should not be listed in release notes labels Nov 10, 2025
@ckerr ckerr mentioned this pull request Dec 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nevack nevack nevack left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

notes:none Should not be listed in release notes scope:mac type:ui

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@livings124 @nevack @ckerr