feat: Add NAT-PMP gateway_address configuration option.
#7735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
ckerr
requested changes
Nov 10, 2025
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
I don't have any strong feelings about the feature & would appreciate another opinion e.g. from other contributors about the feature itself.
Implementation basically LGTM. I have some nit suggestions but nothing serious. Requesting changes for the nits.
ckerr
added
needs code review
needs notes
gtsiam
force-pushed
the
pr/gwaddr
branch
3 times, most recently
from
ab2f704 to
d2f982b
Compare
ckerr
approved these changes
Nov 12, 2025
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
Implementation LGTM.
I'd still appreciate feedback from other @transmission/contributors about the feature itself. Is this something we should use?
Author
|
Would be nice if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My C++ skills are rusty (pun intended) and this isn't an easy code base to navigate. Nevertheless, this does the job.
With this change, you can set the gateway address used by libnatpmp in
settings.json:Fixes #6457.
PS: With arch linux (clang 21.1.4):
I just did
TR_SKIP_HOOKS=1 git commit.