Skip to content

Feature/lesson3 duy#10

Merged
truongnguyenptit merged 11 commits intofeature/lesson3from
feature/lesson3-duy
Aug 4, 2019
Merged

Feature/lesson3 duy#10
truongnguyenptit merged 11 commits intofeature/lesson3from
feature/lesson3-duy

Conversation

@DoKhuongDuy
Copy link
Copy Markdown

Help me check Lesson3. Thank you!

@DoKhuongDuy DoKhuongDuy requested a review from canhdh2 August 1, 2019 14:59
Copy link
Copy Markdown

@canhdh2 canhdh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xóa quá nhiều dòng thiết yếu, nên xem lại để hiểu kỹ hơn cách sử dụng XML


<groupId>com.trainingdeveloperpro.k001</groupId>
<artifactId>java-k001</artifactId>
<groupId>java-k001-backend-lesson3-Duy</groupId>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t nghĩ groupId với artifactId nên để trùng với groupId và artifactId với project chung

@@ -1,13 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

những dòng này phải để nha nếu k pull về ko chạy đc

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dòng này

<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cả dòng này

xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">

<bean id="dataResource" class="com.k001.trainingdeveloper.javabackend.demoapplicationcontext.DataResource">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

và dòng này nữa

<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-beans</artifactId>
<version>5.2.0.BUILD-SNAPSHOT</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

các dependency phải đầy đủ có spring-beans và spring-context nhé, không được xóa đi

<property name="password" value="admin1234" />
</bean>

</beans>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dòng này cũng ko được xóa

xsi:schemaLocation = "http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">

<bean id = "helloWorld" class = "com.k001.trainingdeveloper.javabackend.demobean.HelloWorld" >
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

và tất cả những dòng ở file này nữa, nếu xóa đi sẽ bị lỗi ko chạy đc

@truongnguyenptit truongnguyenptit merged commit f2472cc into feature/lesson3 Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants