Skip to content

Commit fece5b2

Browse files
mrcfpscmccandless
authored andcommitted
palindrome-products: update tests to v1.1.0 (exercism#1308)
* palindrome-products: update tests to v1.1.0 * Update version number * Use `assertRaisesWithMessage` * palindrome-products: remove redundant comment
1 parent cfa4287 commit fece5b2

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

exercises/palindrome-products/palindrome_products_test.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from palindrome_products import smallest_palindrome, largest_palindrome
1717

1818

19-
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0
19+
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0
2020

2121
class PalindromesTests(unittest.TestCase):
2222
def test_smallest_palindrome_from_single_digit_factors(self):
@@ -60,24 +60,32 @@ def test_largest_palindrome_from_four_digit_factors(self):
6060
self.assertFactorsEqual(factors, {(9901, 9999)})
6161

6262
def test_empty_for_smallest_palindrome_if_none_in_range(self):
63-
with self.assertRaises(ValueError):
63+
with self.assertRaisesWithMessage(ValueError):
6464
value, factors = smallest_palindrome(min_factor=1002,
6565
max_factor=1003)
6666

6767
def test_empty_for_largest_palindrome_if_none_in_range(self):
68-
with self.assertRaises(ValueError):
68+
with self.assertRaisesWithMessage(ValueError):
6969
value, factors = largest_palindrome(min_factor=15, max_factor=15)
7070

7171
def test_error_for_smallest_if_min_is_more_than_max(self):
72-
with self.assertRaises(ValueError):
72+
with self.assertRaisesWithMessage(ValueError):
7373
value, factors = smallest_palindrome(min_factor=10000,
7474
max_factor=1)
7575

7676
def test_error_for_largest_if_min_is_more_than_max(self):
77-
with self.assertRaises(ValueError):
77+
with self.assertRaisesWithMessage(ValueError):
7878
value, factors = largest_palindrome(min_factor=2, max_factor=1)
7979

80-
# Utility methods
80+
# Utility functions
81+
def setUp(self):
82+
try:
83+
self.assertRaisesRegex
84+
except AttributeError:
85+
self.assertRaisesRegex = self.assertRaisesRegexp
86+
87+
def assertRaisesWithMessage(self, exception):
88+
return self.assertRaisesRegex(exception, r".+")
8189

8290
def assertFactorsEqual(self, actual, expected):
8391
self.assertEqual(set(map(frozenset, actual)),

0 commit comments

Comments
 (0)