Commit ba100f8
committed
Address Copilot review on JavaScriptSolidServer#287
1. Move the orphaned /** Registration page HTML */ docblock back above
registerPage where it belongs — it had been pushed off its function
when the new landingPage was inserted ahead of it.
2. /idp/auth no-client_id guard now triggers only when the parameter is
truly absent (=== undefined), not when it's present-but-empty. An
explicit ?client_id= is a malformed OIDC request and oidc-provider
should be the one to surface the spec error, not us silently
redirecting to the friendly landing.1 parent cc68744 commit ba100f8
2 files changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
550 | 550 | | |
551 | 551 | | |
552 | 552 | | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | 553 | | |
557 | 554 | | |
558 | 555 | | |
| |||
624 | 621 | | |
625 | 622 | | |
626 | 623 | | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
627 | 627 | | |
628 | 628 | | |
629 | 629 | | |
| |||
0 commit comments