Skip to content

Merge Upstream - #21

Merged
asherf merged 21 commits into
toolchainlabs:masterfrom
asherf:costanza
Nov 18, 2020
Merged

asherf merged 21 commits into
toolchainlabs:masterfrom
asherf:costanza

Conversation

@asherf

@asherf asherf commented Nov 18, 2020

Copy link
Copy Markdown
Member

No description provided.

danieljanes and others added 21 commits July 24, 2020 08:49
Required moving the .proto files to be
below the exported target (in the filesystem
sense).

If we support setting a source root on
generated protos in the future, we can
modify this further to demo that.
Remaining followups:

* [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI.
* [ ] Turn on dependency inference. Needs docs update.
* [ ] Enable MyPy.
* [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update.
* [ ] Use `resolve_all_constraints`. Needs docs update.
* [ ] Fix all references to readme.io. Fix the `master` branch too.
* [ ] Update the `./pants` script. Fix the `master` branch too.
Otherwise `./pants run helloworld:helloworld_py2` doesn't work.
Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA.
This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints.
This prepares us for 2.2 removing support for running with Py36.
@asherf
asherf merged commit 96040d7 into toolchainlabs:master Nov 18, 2020
@asherf
asherf deleted the costanza branch November 18, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants