test: have server.set_auth accepting strings (microsoft#1016)

mxschmitt · web-flow · commit bc230474fcb8 · 2021-11-09T14:11:29.000+01:00
diff --git a/tests/async/test_browsercontext.py b/tests/async/test_browsercontext.py
@@ -535,14 +535,14 @@ async def test_route_should_fall_back_to_context_route(context, server):
 
 
 async def test_auth_should_fail_without_credentials(context, server):
-    server.set_auth("/empty.html", b"user", b"pass")
+    server.set_auth("/empty.html", "user", "pass")
     page = await context.new_page()
     response = await page.goto(server.EMPTY_PAGE)
     assert response.status == 401
 
 
 async def test_auth_should_work_with_correct_credentials(browser, server):
-    server.set_auth("/empty.html", b"user", b"pass")
+    server.set_auth("/empty.html", "user", "pass")
     context = await browser.new_context(
         http_credentials={"username": "user", "password": "pass"}
     )
@@ -553,7 +553,7 @@ async def test_auth_should_work_with_correct_credentials(browser, server):
 
 
 async def test_auth_should_fail_with_wrong_credentials(browser, server):
-    server.set_auth("/empty.html", b"user", b"pass")
+    server.set_auth("/empty.html", "user", "pass")
     context = await browser.new_context(
         http_credentials={"username": "foo", "password": "bar"}
     )
@@ -564,7 +564,7 @@ async def test_auth_should_fail_with_wrong_credentials(browser, server):
 
 
 async def test_auth_should_return_resource_body(browser, server):
-    server.set_auth("/playground.html", b"user", b"pass")
+    server.set_auth("/playground.html", "user", "pass")
     context = await browser.new_context(
         http_credentials={"username": "user", "password": "pass"}
     )
diff --git a/tests/async/test_defaultbrowsercontext.py b/tests/async/test_defaultbrowsercontext.py
@@ -188,7 +188,7 @@ async def test_should_support_http_credentials_option(server, launch_persistent)
     (page, context) = await launch_persistent(
         http_credentials={"username": "user", "password": "pass"}
     )
-    server.set_auth("/playground.html", b"user", b"pass")
+    server.set_auth("/playground.html", "user", "pass")
     response = await page.goto(server.PREFIX + "/playground.html")
     assert response.status == 200
 
diff --git a/tests/async/test_popup.py b/tests/async/test_popup.py
@@ -114,7 +114,7 @@ async def test_should_inherit_offline_from_browser_context(context, server):
 async def test_should_inherit_http_credentials_from_browser_context(
     browser: Browser, server
 ):
-    server.set_auth("/title.html", b"user", b"pass")
+    server.set_auth("/title.html", "user", "pass")
     context = await browser.new_context(
         http_credentials={"username": "user", "password": "pass"}
     )
diff --git a/tests/server.py b/tests/server.py
@@ -98,8 +98,8 @@ def process(self) -> None:
                     creds_correct = False
                     if authorization_header:
                         creds_correct = auth.get(path) == (
-                            request.getUser(),
-                            request.getPassword(),
+                            request.getUser().decode(),
+                            request.getPassword().decode(),
                         )
                     if not creds_correct:
                         request.setHeader(

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ async def test_should_support_http_credentials_option(server, launch_persistent)`
`188`	`188`	`(page, context) = await launch_persistent(`
`189`	`189`	`http_credentials={"username": "user", "password": "pass"}`
`190`	`190`	`)`
`191`		`- server.set_auth("/playground.html", b"user", b"pass")`
	`191`	`+ server.set_auth("/playground.html", "user", "pass")`
`192`	`192`	`response = await page.goto(server.PREFIX + "/playground.html")`
`193`	`193`	`assert response.status == 200`
`194`	`194`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ async def test_should_inherit_offline_from_browser_context(context, server):`
`114`	`114`	`async def test_should_inherit_http_credentials_from_browser_context(`
`115`	`115`	`browser: Browser, server`
`116`	`116`	`):`
`117`		`- server.set_auth("/title.html", b"user", b"pass")`
	`117`	`+ server.set_auth("/title.html", "user", "pass")`
`118`	`118`	`context = await browser.new_context(`
`119`	`119`	`http_credentials={"username": "user", "password": "pass"}`
`120`	`120`	`)`