tests: fix flaky tests iteration 2 (microsoft#719)

mxschmitt · web-flow · commit 1dc74331a052 · 2021-05-24T23:23:40.000+02:00
diff --git a/tests/async/test_page.py b/tests/async/test_page.py
@@ -17,6 +17,7 @@
 import re
 
 import pytest
+from flaky import flaky
 
 from playwright.async_api import Error, TimeoutError
 
@@ -763,6 +764,7 @@ async def test_select_option_should_select_only_first_option(page, server):
     assert await page.evaluate("result.onChange") == ["blue"]
 
 
+@flaky  # TODO: https://github.com/microsoft/playwright/issues/6725
 async def test_select_option_should_not_throw_when_select_causes_navigation(
     page, server
 ):
diff --git a/tests/async/test_tracing.py b/tests/async/test_tracing.py
@@ -14,9 +14,13 @@
 
 from pathlib import Path
 
+import pytest
+
 from playwright.async_api import BrowserType
 
 
+# TODO: Currenty broken upstream
+@pytest.mark.skip
 async def test_browser_context_output_trace(
     browser_type: BrowserType, server, tmp_path: Path, launch_arguments
 ):
@@ -28,7 +32,6 @@ async def test_browser_context_output_trace(
     page = await context.new_page()
     await page.goto(server.PREFIX + "/grid.html")
     await context.tracing.stop()
-    await page.wait_for_timeout(1000)
     await context.tracing.export(Path(tmp_path / "traces" / "trace.zip").resolve())
     assert Path(tmp_path / "traces" / "trace.zip").exists()
     assert Path(tmp_path / "traces" / "resources").exists()
diff --git a/tests/async/test_websocket.py b/tests/async/test_websocket.py
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 import pytest
+from flaky import flaky
 
 from playwright.async_api import Error
 
@@ -109,6 +110,7 @@ def on_web_socket(ws):
     assert received == ["incoming", b"\x04\x02"]
 
 
+@flaky
 async def test_should_reject_wait_for_event_on_close_and_error(page, ws_server):
     async with page.expect_event("websocket") as ws_info:
         await page.evaluate(
