fix(endpoints): wait flag should make it wait#270
Merged
blainekasten merged 2 commits intomainfrom Nov 26, 2025
Merged
Conversation
blainekasten
approved these changes
Nov 26, 2025
Contributor
blainekasten
left a comment
blainekasten
left a comment
There was a problem hiding this comment.
I tested and experienced this as well! Thank you for the PR - I'll also be porting this over to our v2 library!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
clickv8, the behaviour of flags is a bit different than I expected. If the default isTrue, and you pass in that flag, it will invert (toFalse). The actual solution is this.Context: https://stackoverflow.com/questions/53957389/how-does-python-click-library-handle-options-that-are-flags-and-true-by-default
Because of this, if you pass
--waittotogether endpoints create, it will actually not wait! Oops.Note
Fix wait behavior by replacing
--waitflags with--wait/--no-wait(default true) for endpoint create/start/stop commands.--waitto--wait/--no-waitwith defaultTrueforcreate,start, andstopto ensure correct wait behavior.Written by Cursor Bugbot for commit ef4ee1d. This will update automatically on new commits. Configure here.