feat: round robin selection in virtualizers#4818
Open
frihetselsker wants to merge 1 commit into
Open
Conversation
alexandruradovici
approved these changes
Apr 30, 2026
Contributor
|
I am not sure why the CI fails, but it does not seem to be due to the modified code. |
Contributor
|
Can we create a |
Member
|
Some of the test are failing because this new round-robin policy results (as expected and correctly) in interleaved UART messages between the kernel and applications which in This is basically a problem with the tests, not the implementation or policy in this PR, but we need to fix those tests in order to merge this. It's still unclear how to best fix those tests yet, so investigating and suggestions welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes the fairness problem of virtual devices. The solution iterates the devices list in a round robin manner and is introduced at every multiplexer (except
VirtualTimerandVirtualMuxAlarmwhich have different implementation). For more details, please refer to #4802.Testing Strategy
This pull request was tested by using a custom kernel of qemu_rv32_virt with UART peripheral, and three equivalent applications that try to use printf() simultaneously.
TODO or Help Wanted
Feedback
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.AI Use
code in this PR, if any, and I have manually checked and
personally certify the entire contents of this PR.
No AI was used in this PR.