Skip to content

chore: remove dangling symlink files that points to nothing.#533

Open
gelocraft wants to merge 1 commit intotmux-plugins:masterfrom
gelocraft:remove-run_tests-file
Open

chore: remove dangling symlink files that points to nothing.#533
gelocraft wants to merge 1 commit intotmux-plugins:masterfrom
gelocraft:remove-run_tests-file

Conversation

@gelocraft
Copy link

@gelocraft gelocraft commented Jan 30, 2025 •
edited
Loading

this pull request removes the run_tests, tests/helpers/helpers.sh, tests/run_tests_in_isolation files that exists for 10 years and these files are actually symlinks that points to nothing so why not remove it?

Screenshot_20250130-135539

@gelocraft gelocraft changed the title chore: remove/unlink run_tests because it points to nothing. chore: remove/unlink run_tests file because it points to nothing. Jan 30, 2025
@janekx21
Copy link

janekx21 commented Feb 11, 2025 •
edited
Loading

Nix fails to build because of this. Please remove as fast as possbile.

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/b1lslyrp352w12m41ik8yxx8zz1p0n45-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
shrinking RPATHs of ELF executables and libraries in /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01
checking for references to /build/ in /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01...
patching script interpreter paths in /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/save_command_strategies/pgrep.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/save_command_strategies/linux_procfs.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/save_command_strategies/gdb.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/save_command_strategies/ps.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/resurrect.tmux: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/scripts/restore.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/scripts/save.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/scripts/tmux_spinner.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/scripts/check_tmux_version.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/tests/test_resurrect_restore.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/tests/test_resurrect_save.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/strategies/nvim_session.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/strategies/irb_default_strategy.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/strategies/vim_session.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
/nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/strategies/mosh-client_default_strategy.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/fd118hwh7d1ncib4mdw56ylv3g9k0iyj-bash-5.2p37/bin/bash"
ERROR: noBrokenSymlinks: the symlink /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/run_tests points to a missing target /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/lib/tmux-test/run_tests
ERROR: noBrokenSymlinks: the symlink /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/tests/run_tests_in_isolation points to a missing target /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/lib/tmux-test/tests/run_tests_in_isolation
ERROR: noBrokenSymlinks: the symlink /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/tests/helpers/helpers.sh points to a missing target /nix/store/jmkvy216mirw8fzchnis8683si0bqgc3-tmuxplugin-resurrect-unstable-2022-05-01/share/tmux-plugins/resurrect/lib/tmux-test/tests/helpers/helpers.sh
ERROR: noBrokenSymlinks: found 3 dangling symlinks and 0 reflexive symlinks

@gelocraft
Copy link
Author

gelocraft commented Feb 11, 2025 •
edited
Loading

@janekx21 but my pull request hasn't even merged yet? what is the problem?

@janekx21
Copy link

janekx21 commented Feb 11, 2025

The nix derivation does not build. But i got this workaround.

(tmuxPlugins.resurrect.overrideAttrs (oldAttrs: {
  preFixup = (oldAttrs.preFixup or "") + ''
    rm $out/share/tmux-plugins/resurrect/run_tests
    rm $out/share/tmux-plugins/resurrect/tests/run_tests_in_isolation
    rm $out/share/tmux-plugins/resurrect/tests/helpers/helpers.sh
    # clean up other dangling symlinks here...
  '';
}))

@janekx21
Copy link

janekx21 commented Feb 11, 2025 •
edited
Loading

@gelocraft

The problem is not your PR. The problem is the current state. Your PR is a partial solution.

Nix seams very strict about broken links ^^

@gelocraft gelocraft force-pushed the remove-run_tests-file branch from e7bf790 to 3b80a7f Compare February 11, 2025 13:49
@gelocraft
Copy link
Author

gelocraft commented Feb 11, 2025

@gelocraft

The problem is not your PR. The problem is the current state. Your PR is a partial solution.

Nix seams very strict about broken links ^^

I've removed run_tests, tests/run_tests_in_isolation, and tests/helpers/helpers.sh. This PR should fixed your problem with nix once got merged by the maintainer.

@gelocraft gelocraft changed the title chore: remove/unlink run_tests file because it points to nothing. chore: remove symlink files that points to nothing. Feb 11, 2025
@gelocraft gelocraft changed the title chore: remove symlink files that points to nothing. chore: remove dangling symlink files that points to nothing. Feb 12, 2025
@AVGVSTVS96 AVGVSTVS96 mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gelocraft @janekx21