Remove padding from borderless menus - #5447
Open
Mr-Neutr0n wants to merge 2 commits into
Open
Conversation
Member
|
Looks good but try this: The menu has lines even though that window is configured with |
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
Author
|
Thanks, I reproduced the exact sequence. The issue was that display-menu read menu-border-lines from the current window after neww instead of the explicitly targeted window (%0), so it saw the default border setting. I updated it to use the target window options, added a regression case for this sequence, and verified the rebuilt binary renders the borderless menu. Commit 2776e2e is pushed for recheck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menu-border-linesisnoneAddresses #4897.
Testing
make -j4screen-redraw-menus.shno-border regressionregress/menu-mouse.shcopy-mode-selection-scroll.sh,format-mouse.sh, and themenu-over-splitgoldenPrepared with OpenAI Codex assistance; I reviewed and tested the changes.