Handle User.created_at attributes as datetime objects.

JNRowe · JNRowe · commit 99074a9e82b4 · 2011-05-22T10:19:00.000+01:00
diff --git a/doc/api/core.rst b/doc/api/core.rst
@@ -16,6 +16,8 @@ Core
 .. autofunction:: commitdate_to_datetime
 .. autofunction:: datetime_to_commitdate
 
+.. autofunction:: userdate_to_datetime
+
 .. autofunction:: doc_generator
 
 .. autoclass:: GithubCommand
diff --git a/github2/core.py b/github2/core.py
@@ -59,6 +59,21 @@ def datetime_to_commitdate(datetime_):
     return "".join([date_without_tz, COMMIT_TIMEZONE])
 
 
+def userdate_to_datetime(user_date):
+    """Convert user date string to Python datetime
+
+    Unfortunately this needs a special case because :meth:`~Github.users.show`
+    and :meth:`~Github.users.search` return a different formats for the
+    `created_at` attributes.
+
+    :param str user_date: date string to parse
+    """
+    try:
+        return ghdate_to_datetime(user_date)
+    except ValueError:
+        return strptime(user_date, '%Y-%m-%dT%H:%M:%SZ')
+
+
 class GithubCommand(object):
 
     def __init__(self, request):
@@ -143,6 +158,10 @@ class DateAttribute(Attribute):
             "to": commitdate_to_datetime,
             "from": datetime_to_commitdate,
         },
+        "user": {
+            "to" : userdate_to_datetime,
+            "from": datetime_to_ghdate,
+        }
     }
 
     def __init__(self, *args, **kwargs):
diff --git a/github2/users.py b/github2/users.py
@@ -1,4 +1,4 @@
-from github2.core import BaseData, GithubCommand, Attribute
+from github2.core import BaseData, GithubCommand, DateAttribute, Attribute
 import urllib
 
 
@@ -23,6 +23,8 @@ class User(BaseData):
     private_gist_count = Attribute(
         "Number of private gists owned by the user")
     plan = Attribute("Current active github plan")
+    created_at = DateAttribute("The date this user was registered",
+                               format="user")
 
     def is_authenticated(self):
         """Test for user auththenication
diff --git a/tests/test_user.py b/tests/test_user.py
@@ -1,5 +1,7 @@
 import _setup
 
+import datetime
+
 from nose.tools import (assert_equals, assert_false, assert_true)
 
 import utils
@@ -18,10 +20,8 @@ def test_user(self):
 
     def test_meta(self):
         user = self.client.users.show('defunkt')
-        # Difficult to handle created_at attribute as its content varies
-        # depending on API path.
-        #assert_equals(user.created_at,
-        #              datetime.datetime(2007, 10, 19, 22, 24, 19))
+        assert_equals(user.created_at,
+                      datetime.datetime(2007, 10, 19, 22, 24, 19))
         assert_equals(user.followers_count, 2593)
         assert_equals(user.following_count, 212)
         assert_equals(user.gravatar_id, 'b8dbb1987e8e5318584865f880036796')
