[pull] main from python:main - #1397
Merged
Merged
Conversation
…56103) The setter did not check the value for NULL and passed it to Py_fopen().
…tion (GH-156139) addstr(), addnstr(), insstr() and insnstr() saved the window rendition with getattrs() and put it back with wattrset(), whose A_COLOR field holds only pairs 0 to 255, so a window using a larger pair lost it. Save and restore the pair with wattr_get() and wattr_set() where they exist.
They are the counterparts of the ACS_* line-drawing codes as complexchar cells, added to the module by initscr() and newterm() like the ACS_* ones. Besides the codes that mirror the ACS_* ones, ncurses provides the double-line and thick-line families, which have no ACS_* counterpart.
…H-156104) Deleting the attribute crashed, and setting it to an integer which does not fit in C long reported success with OverflowError set.
In the free-threaded build the setter passed the value to Py_BEGIN_CRITICAL_SECTION2() before checking it for NULL.
…6105) PyLong_AsUInt32() stores 0 in the target on error, so the attribute was clobbered when the assigned value was too large.
) The integer 0 asks for the default character, but it was rejected when passed together with a string character. Choose the drawing function by what the arguments need: only a complexchar cannot be drawn as a byte character, and a string character is narrowed when one is needed. Document the defaults as 0 rather than as the ACS_* codes, which are not defined before initscr(). * Remove the NEWS entry The regression is not in any release: wide characters in border() and box() are new in 3.16.
…l signatures (#155954)
The setter released the old callback before validating the new value, so a failed assignment or a deletion removed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )