Skip to content

Use .ruby-version file #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjschuck wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use .ruby-version file #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,15 @@ jobs:
build:
runs-on: ubuntu-24.04
strategy:
matrix:
ruby-version:
- 3.2.6
fail-fast: false

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Set up Ruby ${{ matrix.ruby-version }}
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
Copy link
Copy Markdown
Author

@tjschuck tjschuck Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruby/setup-ruby?tab=readme-ov-file#single-job

Not needed with a .ruby-version

bundler-cache: true

- name: Install dependencies
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
/config/config.yml

/public/assets
.ruby-version
.rspec

coverage
Expand Down
1 change: 0 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ require:
- rubocop-rspec

AllCops:
TargetRubyVersion: 3.2
Copy link
Copy Markdown
Author

@tjschuck tjschuck Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version

If a TargetRubyVersion is not specified in your config, then RuboCop will check your project for a series of other files where the Ruby version may be specified already. The files that will be checked are (in this order): *.gemspec, .ruby-version, .tool-versions, and Gemfile.lock.

NewCops: enable
Exclude:
- 'db/schema.rb'
Expand Down
2 changes: 1 addition & 1 deletion config/deploy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
set :deploy_to, '/home/apps/t4c'

set :rvm_type, :user
set :rvm_ruby_version, '3.2.6'
set :rvm_ruby_version, File.read("#{File.dirname(__FILE__)}/../.ruby-version").strip
Copy link
Copy Markdown
Author

@tjschuck tjschuck Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style recommended/documented here: https://github.com/capistrano/rbenv?tab=readme-ov-file#usage

set :rvm_custom_path, '~/.rvm'

set :format, :pretty
Expand Down