Skip to content

update conf.c: regular expression for password #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reshadp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update conf.c: regular expression for password #326

reshadp wants to merge 2 commits into from

Conversation

@reshadp
Copy link

@reshadp reshadp commented Sep 30, 2020

Change regular expression for password from [^@]* to .* this matches all characters including the @ character.

Tested with an upstream squid proxy which enforces basic authentication.
I used the following username password combinations to test the following config directives (in a few permutations/combinations)

upstream http proxy:proxy@10.10.20.50:3128
upstream http proxy:proxy@10.10.20.50:3128 "google.com"
upstream http userame:p@ssword@10.10.20.50:3128
upstream http userame:p@ssword@10.10.20.50:3128 "google.com"
upstream http allspecial:ALL~`!@#$%^&*()'_+-={}|\][;"ALL@10.10.20.50:3128
upstream http allspecial:ALL~`!@#$%^&*()'_+-={}|\][;"ALL@10.10.20.50:3128 "google.com"
upstream http proxy:proxy@proxy.test.com:3128
upstream http proxy:proxy@proxy.test.com:3128 "google.com"
upstream http userame:p@ssword@proxy.test.com:3128
upstream http userame:p@ssword@proxy.test.com:3128 "google.com"
upstream http allspecial:ALL~`!@#$%^&*()'_+-={}|\][;"ALL@proxy.test.com:3128
upstream http allspecial:ALL~`!@#$%^&*()'_+-={}|\][;"ALL@proxy.test.com:3128 "google.com"

update conf.c: regular expression for password
0c52651 
Change regular expression for password from `[^@]*` to `.*` this matches all characters including the @ character.
@reshadp reshadp changed the title update conf.c: regular expression for password #1 update conf.c: regular expression for password Oct 1, 2020
@rofl0r rofl0r mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reshadp