log.c Remove obsolete comment #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is related to parsing the filter file. The new code skips leading whitespaces before removing trailing whitespaces and comments. Without doing this, lines with leading whitespace are treated like empty lines (i.e. they are ignored).
Skipping leading whitespace and removing trailing whitespace and comments were swapped to avoid skipping the leading whitespace twice.
I accidentally used tabs instead of spaces. This commit fixes this.
The comment for setup_logging was obsolete. The function log_message() is called, fprintf() isn't. This isn't a problem because of the send_stored_logs() function.
sammyboy221
approved these changes
Jan 6, 2020
Contributor
|
@joffman could you redo your PR so there's only a single commit? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment for setup_logging was obsolete. The function
log_message() is called, fprintf() isn't.
This isn't a problem because of the send_stored_logs() function.