add DO persister tests, fix prefix parsing, fix empty storage handling#282
Merged
jamesgpearce merged 1 commit intotinyplex:mainfrom Jan 14, 2026
Merged
Conversation
Contributor
|
👀 wow, thanks! I'll get these merged in this week. |
| : 0, | ||
| ), | ||
| ); | ||
| if (Object.keys(tables[0]).length === 0 && Object.keys(values[0]).length === 0) { |
Contributor
There was a problem hiding this comment.
we have some utility functions for this but I can apply them
| testMissing: false, | ||
| testAutoLoad: true, | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
In another project I have figured out a good way to add 'real' DurableObject testing via Miniflare. I will try and bring that over here so we can do this in a solid way with less mocking. Nevertheless this was a missing link - thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the Durable Object Storage persister when using a non-empty storagePrefix:
How did you test this change?
There were formerly no tests (!) for this persistence provider. I added a mock structure which allows it to be tested in a way that I believe is idiomatic with the other providers. Initially the first bug was my target, but I discovered the second when I got the test suite to run.