Skip to content

Suppress clang warning: -Wdouble-promotion - #308

Merged
syoyo merged 1 commit into
masterfrom
fix-double-promotion
Jun 1, 2021
Merged

Suppress clang warning: -Wdouble-promotion#308
syoyo merged 1 commit into
masterfrom
fix-double-promotion

Conversation

@syoyo

@syoyo syoyo commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator

This PR fixes the following clang warning report:

./tiny_obj_loader.h:2456:13: warning: implicit conversion increases floating-point precision: 'tinyobj::real_t' (aka 'float') to 'double' [-Wdouble-promotion]
        if (j < 0.0) {
            ^ ~

@syoyo

syoyo commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator Author

There is CI build failure due to missing vcpython2.7 package: https://github.com/tinyobjloader/tinyobjloader/issues/309

Others are fine so it is safe to merge this PR.

@syoyo
syoyo merged commit 0b6a0b5 into master Jun 1, 2021
@syoyo
syoyo deleted the fix-double-promotion branch June 1, 2021 08:22
syoyo added a commit that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant