fix cmake downstream find_package failure in double mode in windows #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Awesome! Merged! |
Contributor
Author
|
@syoyo can we get another release? or retag the 2.0.0-rc2 to the current master, thanks! |
Collaborator
|
@jasjuang Okay, |
syoyo
added a commit
that referenced
this pull request
Nov 10, 2025
fix cmake downstream find_package failure in double mode in windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized I only fixed the problem of #229 for Linux while I was trying to update tinyobjloader for vcpkg. This fix allows double mode to work correctly in windows as well. I've tested it on vcpkg and it installs successfully with this change, and a minimal downstream example also works correctly.