Repository navigation
Conversation
…ll editors The table context toolbar oscillated up and down on every keypress when a small table filled a small editor. When the selection overlapped the toolbar and this wasn't a reposition, the inset layout used LayoutInset.flip, which inverts the current placement. In a small editor both the north and south inset placements overlap the selection, so each keypress flipped to a side that still overlapped, flipping back on the next keypress. Only flip when the opposite placement would actually clear the selection; otherwise preserve the current placement so the toolbar stays put.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket:
Description of Changes:
ContextToolbarAnchor.ts, when the selection overlapped the toolbar and it wasn't a reposition, the inset layout usedLayoutInset.flip, which inverts the current placement. In a small editor both the north and south inset placements overlap the selection, so each keypress flipped to a side that still overlapped, flipping back on the next keypress.ContextToolbarSmallEditorStabilityTest.ts) that fails without the fix and passes with it.Pre-checks:
feature/,hotfix/orspike/Review:
GitHub issues (if applicable): #11175