Skip to content

Fix: MediaResolver invalid after dimensions change - #10768

Open
axww wants to merge 1 commit into
tinymce:mainfrom
axww:hotfix/MediaResolver
Open

Fix: MediaResolver invalid after dimensions change#10768
axww wants to merge 1 commit into
tinymce:mainfrom
axww:hotfix/MediaResolver

Conversation

@axww

@axww axww commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Related Ticket:
#9798

Description of Changes:

  • Run htmlToData again after dimensions changed to prevent custom MediaResolver rules invalid.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):
#9798

Summary by CodeRabbit

  • Bug Fixes
    • Improved the media embed functionality to ensure proper synchronization between embed content and generated HTML, resulting in more reliable embed handling in the editor.

✏️ Tip: You can customize this high-level summary in your review settings.

@axww
axww requested a review from a team as a code owner December 2, 2025 00:41
@axww
axww requested review from TheSpyder, ltrouton and spocke December 2, 2025 00:41
@coderabbitai

coderabbitai Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1) 
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The media plugin's Dialog component now conditionally enriches data with a source extracted from embed HTML during dialog updates. When an embed value exists, the source is derived via HtmlToData conversion before passing to dataToHtml; otherwise, the original data is used.

Changes

Cohort / File(s) Summary
Media Dialog Embed Enrichment
modules/tinymce/src/plugins/media/main/ts/ui/Dialog.ts		 Added conditional logic to enrich data with source extracted from embed HTML (via HtmlToData.htmlToData) when computing embed HTML during dialog updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Understanding the purpose of source enrichment from embed HTML and verifying it doesn't introduce unintended side effects on the embed generation flow
  • Confirming the conditional logic correctly handles both truthy and falsy embed values

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix: MediaResolver invalid after dimensions change' directly matches the PR's stated objective of fixing MediaResolver becoming invalid after dimension changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@axww

axww commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Submit this PR again due to long time hold.
Please check my issue which reproduced this bug:
#9798
Need your help with changelog, I'm not familiar with it.
Please review, many thanks!!

axww
axww commented Sep 23, 2026
View reviewed changes

@axww axww left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 years old bug, please review, thanks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers
@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers
@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axww @TheSpyder