fix: Event processors always get a Hint

untitaker · untitaker · commit bb5abb041853 · 2019-06-01T14:49:21.000+02:00
diff --git a/sentry_sdk/client.py b/sentry_sdk/client.py
@@ -105,6 +105,8 @@ def _prepare_event(
         if event.get("timestamp") is None:
             event["timestamp"] = datetime.utcnow()
 
+        hint = dict(hint or ())  # type: Hint
+
         if scope is not None:
             event = scope.apply_to_event(event, hint)
             if event is None:
@@ -153,7 +155,7 @@ def _prepare_event(
         if before_send is not None:
             new_event = None
             with capture_internal_exceptions():
-                new_event = before_send(event, hint)
+                new_event = before_send(event, hint or {})
             if new_event is None:
                 logger.info("before send dropped event (%s)", event)
             event = new_event  # type: ignore
diff --git a/sentry_sdk/scope.py b/sentry_sdk/scope.py
@@ -170,8 +170,8 @@ def func(event, exc_info):
         self._error_processors.append(func)
 
     @_disable_capture
-    def apply_to_event(self, event, hint=None):
-        # type: (Event, Optional[Hint]) -> Optional[Event]
+    def apply_to_event(self, event, hint):
+        # type: (Event, Hint) -> Optional[Event]
         """Applies the information contained on the scope to the given event."""
 
         def _drop(event, cause, ty):
@@ -207,7 +207,7 @@ def _drop(event, cause, ty):
                 "span_id": self._span.span_id,
             }
 
-        exc_info = hint.get("exc_info") if hint is not None else None
+        exc_info = hint.get("exc_info")
         if exc_info is not None:
             for error_processor in self._error_processors:
                 new_event = error_processor(event, exc_info)
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -32,7 +32,7 @@
     Breadcrumb = Dict[str, Any]
     BreadcrumbHint = Dict[str, Any]
 
-    EventProcessor = Callable[[Event, Optional[Hint]], Optional[Event]]
+    EventProcessor = Callable[[Event, Hint], Optional[Event]]
     ErrorProcessor = Callable[[Event, ExcInfo], Optional[Event]]
     BreadcrumbProcessor = Callable[[Breadcrumb, BreadcrumbHint], Optional[Breadcrumb]]
 
