fix(sanic): Don't report 400 as error

untitaker · untitaker · commit b50b0b365ea8 · 2018-10-19T14:44:51.000+02:00
Fix getsentry#127
diff --git a/sentry_sdk/integrations/sanic.py b/sentry_sdk/integrations/sanic.py
@@ -10,6 +10,7 @@
 from sentry_sdk.integrations.logging import ignore_logger
 
 from sanic import Sanic
+from sanic.exceptions import SanicException
 from sanic.router import Router
 from sanic.handlers import ErrorHandler
 
@@ -94,6 +95,9 @@ async def sentry_wrapped_error_handler(request, exception):
 
 
 def _capture_exception(exception):
+    if isinstance(exception, SanicException):
+        return
+
     hub = Hub.current
     integration = hub.get_integration(SanicIntegration)
     if integration is None:
diff --git a/tests/integrations/flask/test_flask.py b/tests/integrations/flask/test_flask.py
@@ -5,7 +5,7 @@
 
 flask = pytest.importorskip("flask")
 
-from flask import Flask, request
+from flask import Flask, request, abort
 
 from flask_login import LoginManager, login_user
 
@@ -445,3 +445,18 @@ def error_handler(err):
 
     exception, = event2["exception"]["values"]
     assert exception["type"] == "ZeroDivisionError"
+
+
+def test_bad_request_not_captured(sentry_init, capture_events, app):
+    sentry_init(integrations=[flask_sentry.FlaskIntegration()])
+    events = capture_events()
+
+    @app.route("/")
+    def index():
+        abort(400)
+
+    client = app.test_client()
+
+    client.get("/")
+
+    assert not events
diff --git a/tests/integrations/sanic/test_sanic.py b/tests/integrations/sanic/test_sanic.py
@@ -7,6 +7,7 @@
 from sentry_sdk.integrations.sanic import SanicIntegration
 
 from sanic import Sanic, request, response
+from sanic.exceptions import abort
 
 
 @pytest.fixture
@@ -73,6 +74,20 @@ def myerror(request):
     )
 
 
+def test_bad_request_not_captured(sentry_init, app, capture_events):
+    sentry_init(integrations=[SanicIntegration()])
+    events = capture_events()
+
+    @app.route("/")
+    def index(request):
+        abort(400)
+
+    request, response = app.test_client.get("/")
+    assert response.status == 400
+
+    assert not events
+
+
 def test_error_in_errorhandler(sentry_init, app, capture_events):
     sentry_init(integrations=[SanicIntegration()])
     events = capture_events()
