bugfix: should not crash when no request context

untitaker · untitaker · commit 94ce9b468079 · 2018-07-27T05:09:25.000+02:00
diff --git a/sentry_sdk/integrations/flask.py b/sentry_sdk/integrations/flask.py
@@ -49,17 +49,18 @@ def _capture_exception(sender, exception, **kwargs):
 
 
 def _event_processor(event):
-    if "transaction" not in event:
+    if request:
+        if "transaction" not in event:
+            try:
+                event["transaction"] = request.url_rule.endpoint
+            except Exception:
+                get_current_hub().capture_internal_exception()
+
         try:
-            event["transaction"] = request.url_rule.endpoint
+            FlaskRequestExtractor(request).extract_into_event(event)
         except Exception:
             get_current_hub().capture_internal_exception()
 
-    try:
-        FlaskRequestExtractor(request).extract_into_event(event)
-    except Exception:
-        get_current_hub().capture_internal_exception()
-
     try:
         _set_user_info(event)
     except Exception:
@@ -99,10 +100,13 @@ def _set_user_info(event):
     if "user" in event:
         return
 
-    try:
-        ip_address = request.access_route[0]
-    except IndexError:
-        ip_address = request.remote_addr
+    if request:
+        try:
+            ip_address = request.access_route[0]
+        except IndexError:
+            ip_address = request.remote_addr
+    else:
+        ip_address = None
 
     user_info = {"id": None, "ip_address": ip_address}
 
diff --git a/tests/integrations/flask/test_flask.py b/tests/integrations/flask/test_flask.py
@@ -9,7 +9,7 @@
 
 from flask_login import LoginManager, login_user
 
-from sentry_sdk import capture_message, Client, get_current_hub
+from sentry_sdk import capture_message, Client, get_current_hub, capture_exception
 import sentry_sdk.integrations.flask as flask_sentry
 
 get_current_hub().bind_client(Client(integrations=["flask", "logging"]))
@@ -278,3 +278,8 @@ def index():
 
     event, = capture_events
     assert event["level"] == "error"
+
+
+def test_no_errors_without_request(app):
+    with app.app_context():
+        capture_exception(ValueError())
