fix: Missing traceback in celery

untitaker · untitaker · commit 4038bdc4a2f0 · 2018-10-05T15:30:33.000+02:00
Fix getsentry#107
diff --git a/sentry_sdk/integrations/celery.py b/sentry_sdk/integrations/celery.py
@@ -1,5 +1,7 @@
 from __future__ import absolute_import
 
+import sys
+
 from celery.signals import task_failure, task_prerun, task_postrun
 from celery.exceptions import SoftTimeLimitExceeded
 
@@ -20,6 +22,9 @@ def install(self):
         task_failure.connect(self._process_failure_signal, weak=False)
 
     def _process_failure_signal(self, sender, task_id, einfo, **kw):
+        # einfo from celery is not reliable
+        exc_info = sys.exc_info()
+
         if hasattr(sender, "throws") and isinstance(einfo.exception, sender.throws):
             return
 
@@ -33,9 +38,9 @@ def _process_failure_signal(self, sender, task_id, einfo, **kw):
                         getattr(sender, "name", sender),
                     ]
 
-                self._capture_event(hub, einfo.exc_info)
+                self._capture_event(hub, exc_info)
         else:
-            self._capture_event(hub, einfo.exc_info)
+            self._capture_event(hub, exc_info)
 
     def _capture_event(self, hub, exc_info):
         event, hint = event_from_exception(
diff --git a/tests/integrations/celery/test_celery.py b/tests/integrations/celery/test_celery.py
@@ -20,6 +20,7 @@ def test_simple(capture_events, celery):
 
     @celery.task(name="dummy_task")
     def dummy_task(x, y):
+        foo = 42
         return x / y
 
     dummy_task.delay(1, 2)
@@ -29,9 +30,8 @@ def dummy_task(x, y):
 
     exception, = event["exception"]["values"]
     assert exception["type"] == "ZeroDivisionError"
-
-    event, = events
-    assert event["exception"]["values"][0]["mechanism"]["type"] == "celery"
+    assert exception["mechanism"]["type"] == "celery"
+    assert exception["stacktrace"]["frames"][1]["vars"]["foo"] == "42"
 
 
 def test_ignore_expected(capture_events, celery):
