fix: Update mypy

untitaker · untitaker · commit 24c084d4e656 · 2019-09-27T18:22:01.000+02:00
diff --git a/sentry_sdk/client.py b/sentry_sdk/client.py
@@ -43,7 +43,7 @@ def _get_options(*args, **kwargs):
         dsn = None
 
     rv = dict(DEFAULT_OPTIONS)
-    options = dict(*args, **kwargs)  # type: ignore
+    options = dict(*args, **kwargs)
     if dsn is not None and options.get("dsn") is None:
         options["dsn"] = dsn
 
diff --git a/sentry_sdk/hub.py b/sentry_sdk/hub.py
@@ -347,10 +347,10 @@ def capture_exception(
         client = self.client
         if client is None:
             return None
-        if error is None:
-            exc_info = sys.exc_info()
-        else:
+        if error is not None:
             exc_info = exc_info_from_error(error)
+        else:
+            exc_info = sys.exc_info()
 
         event, hint = event_from_exception(exc_info, client_options=client.options)
         try:
diff --git a/sentry_sdk/integrations/flask.py b/sentry_sdk/integrations/flask.py
@@ -113,11 +113,10 @@ def _request_started(sender, **kwargs):
             pass
 
         weak_request = weakref.ref(request)
-        scope.add_event_processor(
-            _make_request_event_processor(  # type: ignore
-                app, weak_request, integration
-            )
+        evt_processor = _make_request_event_processor(
+            app, weak_request, integration  # type: ignore
         )
+        scope.add_event_processor(evt_processor)
 
 
 class FlaskRequestExtractor(RequestExtractor):
diff --git a/sentry_sdk/integrations/stdlib.py b/sentry_sdk/integrations/stdlib.py
@@ -150,7 +150,7 @@ def _install_subprocess():
     def sentry_patched_popen_init(self, *a, **kw):
         hub = Hub.current
         if hub.get_integration(StdlibIntegration) is None:
-            return old_popen_init(self, *a, **kw)
+            return old_popen_init(self, *a, **kw)  # type: ignore
 
         # Convert from tuple to list to be able to set values.
         a = list(a)
@@ -184,7 +184,7 @@ def sentry_patched_popen_init(self, *a, **kw):
         with hub.start_span(op="subprocess", description=description) as span:
             span.set_data("subprocess.cwd", cwd)
 
-            rv = old_popen_init(self, *a, **kw)
+            rv = old_popen_init(self, *a, **kw)  # type: ignore
 
             span.set_tag("subprocess.pid", self.pid)
             return rv
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -482,6 +482,7 @@ def walk_exception_chain(exc_info):
         while (
             exc_type is not None
             and exc_value is not None
+            and tb is not None
             and id(exc_value) not in seen_exception_ids
         ):
             yield exc_type, exc_value, tb
diff --git a/sentry_sdk/worker.py b/sentry_sdk/worker.py
@@ -58,7 +58,7 @@ def _timed_queue_join(self, timeout):
             all_tasks_done = None
 
         try:
-            while queue.unfinished_tasks:  # type: ignore
+            while queue.unfinished_tasks:
                 delay = deadline - time()
                 if delay <= 0:
                     return False
diff --git a/tox.ini b/tox.ini
@@ -154,7 +154,7 @@ deps =
     linters: black
     linters: flake8
     linters: flake8-import-order
-    linters: mypy>=0.720
+    linters: mypy>=0.730
 
     # https://github.com/PyCQA/flake8-bugbear/pull/77
     linters: git+https://github.com/untitaker/flake8-bugbear#branch=fix/b901-yield-expr
