refactor(app): replace deprecated req.connection with req.socket - #523
Open
CharoenwitKunna wants to merge 1 commit into
Open
CharoenwitKunna wants to merge 1 commit into
CharoenwitKunna wants to merge 1 commit into
Conversation
Member
|
It's a type-only deprecation right? Does Express also deprecate it or it's only concerning node http module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces deprecated
req.connectionusage withreq.socket(Node 13+).getIP/getIPsnow usePick<Request, 'headers' | 'socket'>— matchesforwardedandproxy-addrwhich already migrated to socket-onlyRequest.connectionkept for BC but marked@deprecatedZero runtime
req.connectionhits remain; only the deprecated interface alias stays for compatibility.Related to #316 pattern.