Skip to content

WIP: FIDO2 + WebAuthn#2

Open
Jc2k wants to merge 7 commits intomasterfrom
fido2
Open

WIP: FIDO2 + WebAuthn#2
Jc2k wants to merge 7 commits intomasterfrom
fido2

Conversation

@Jc2k
Copy link
Copy Markdown
Collaborator

@Jc2k Jc2k commented Aug 11, 2018

Adds support for attaching FIDO2/WebAuth backed credentials to a tinyauth user, including admin interface. This also forces 2FA using the WebAuth token for the tinyauth management UI.

This does not add WebAuthn support to other web ui's using tinyauth yet.

Todo:

  • Validate RP ID / origin / etc
  • Generate appropriate challenges.
  • Handle sign_count properly
  • Write a mock/fake token so can test the new API's
  • Test with a FIDO2 token

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2018

Codecov Report

Merging #2 into master will decrease coverage by 1.19%.
The diff coverage is 87.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #2     +/-   ##
=========================================
- Coverage   94.86%   93.66%   -1.2%     
=========================================
  Files          47       50      +3     
  Lines        2356     2621    +265     
=========================================
+ Hits         2235     2455    +220     
- Misses        121      166     +45
Impacted Files Coverage Δ
tinyauth/app.py 98.61% <100%> (+0.01%) ⬆️
...nyauth/tests/test_resources_webauthn_credential.py 100% <100%> (ø)
tinyauth/tests/fido2.py 100% <100%> (ø)
tinyauth/tests/test_frontend.py 98.67% <100%> (+0.15%) ⬆️
tinyauth/resources/__init__.py 100% <100%> (ø) ⬆️
tinyauth/resources/webauthn_credential.py 77.35% <77.35%> (ø)
tinyauth/frontend.py 79.33% <81.81%> (-14.26%) ⬇️
tinyauth/models.py 98.63% <90%> (-1.37%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2ee6a...531f419. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant