Show fancier version comparison in update dialog#1916
Merged
jdeanwallace merged 3 commits intomasterfrom Sep 30, 2025
Merged
Conversation
jdeanwallace
changed the title
Contributor
Author
Automated comment from CodeApprove ➜⏳ @jotaen4tinypilot please review this Pull Request |
jotaen4tinypilot
previously requested changes
Sep 29, 2025
Contributor
jotaen4tinypilot
left a comment
jotaen4tinypilot
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
Cool, that looks quite nice now!
In: app/templates/custom-elements/update-dialog.html:
> Line 104
<div class="icon-long-arrow"></div>
It looks like the arrow doesn’t show up. I think we need to import icons.css and backport the icon-long-arrow definitions from Pro.
👀 @jdeanwallace it's your turn please take a look
jdeanwallace
commented
Sep 30, 2025
Contributor
Author
jdeanwallace
left a comment
jdeanwallace
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: app/templates/custom-elements/update-dialog.html:
> Line 105
<div class="icon-long-arrow"></div>
Oh yes, fixed. Thanks!
jotaen4tinypilot
approved these changes
Sep 30, 2025
Contributor
jotaen4tinypilot
left a comment
jotaen4tinypilot
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
jotaen4tinypilot
dismissed
their stale review
Review approved on CodeApprove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/tiny-pilot/tinypilot-pro/issues/1620
This PR backports the version comparison UI from Pro's update-dialog (based on our discussion here).
Note that Community version strings look something like this
0.0.0-0+aaaaaaa(whereaaaaaaais the git commit short hash). We purposefully strip the commit hash from being displayed because it doesn't look as nice.End result: