Update hostname error message to avoid adding .local suffix#1883
Merged
Update hostname error message to avoid adding .local suffix#1883
Conversation
Collaborator
Author
Automated comment from CodeApprove ➜⏳ @db39 please review this Pull Request |
db39
approved these changes
May 22, 2025
Contributor
db39
left a comment
db39
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM, thanks!
Could we adjust the PR description to remove this sentence, the previous message wasn't misleading: "The previous message was misleading, as users do not need to add .local explicitly."
👀 @str028 it's your turn please take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1879
This change updates the error message related to changing the hostname with a
.localsuffix. The previous message was misleading, as users do not need to add.localexplicitly. The updated message now clearly instructs users to avoid adding.local, making the guidance more accurate and user-friendly.