Merged
Conversation
jovanmaric
force-pushed
the
fix/get_body
branch
2 times, most recently
from
aaea43a to
69ce8aa
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the HTTP method selection in the result method to correctly use GET requests when no commands are present and POST requests when commands are present.
- Changed
resultmethod logic to conditionally use GET vs POST based on presence of commands - Updated test descriptions and added comprehensive test coverage for both request types
- Fixed test stubs to match the actual HTTP methods being used
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/tinify/source.rb | Modified result method to use GET for empty commands and POST for non-empty commands |
| test/tinify_source_test.rb | Updated test stubs from GET to POST and added new test cases for request method verification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jovanmaric
force-pushed
the
fix/get_body
branch
from
69ce8aa to
2899b54
Compare
rkoopmans
approved these changes
Sep 24, 2025
jovanmaric
force-pushed
the
fix/get_body
branch
from
2899b54 to
9343f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Tinify::Sourceresult instance method, to use a:postwhen a body is provided. Otherwise use a:get.