fix: removed GET with body from result() call and replaced with POST …#52
Merged
fix: removed GET with body from result() call and replaced with POST …#52
Conversation
…to prepare for deprecation of GET with body from API.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Tinify API client to replace HTTP GET requests with request body with POST requests to prepare for the deprecation of GET with body from the API. The change maintains existing functionality while adapting to upcoming API changes.
- Modified the
result()method to conditionally use GET (when no commands) or POST (when commands are present) - Updated all test files to mock POST requests instead of GET requests when a request body is involved
- Incremented package version to 1.8.2 and added changelog entry
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tinify/Source.ts | Updated result() method to use POST when commands are present, GET when no commands |
| test/tinify-test.js | Updated test mocks from GET to POST for requests with body |
| test/tinify-source-test.js | Updated test mocks from GET to POST for requests with body |
| package.json | Version bump to 1.8.2 |
| CHANGES.md | Added changelog entry for version 1.8.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rkoopmans
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to prepare for deprecation of GET with body from API.