Fix int overflow in Arrow text body buffer computation#9807
Open
akuzm wants to merge 1 commit into
Open
Conversation
The PG text values can be up to 1GB in size, so the computation for extending the Arrow text body buffer could overflow. Switch it to use the Size type.
|
@antekresic, @svenklemm: please review this pull request.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| ); | ||
| select count(compress_chunk(c)) from show_chunks('t_textoverflow') c; | ||
|
|
||
| set timescaledb.debug_require_vector_agg to 'require'; |
Member
There was a problem hiding this comment.
I got LLM Fuzzer repro and error message as well and after applying similar fix but on a different repro I get this (see repro here: https://github.com/timescale/timescaledb/actions/runs/25753178490)
SELECT count(text_col || repeat('x', 2000000)) FROM t_text_overflow;
ERROR: invalid memory alloc request size 2220001281
Could we please also check the repro in the link after this fix?
Member
Author
There was a problem hiding this comment.
Yeah, looks like this needs more work... I'll add this reproducer too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PG text values can be up to 1GB in size, so the computation for extending the Arrow text body buffer could overflow. Switch it to use the Size type.