Skip to content

[to #763] Pick bug fixes of API v2 codec to master#769

Merged
iosmanthus merged 4 commits into
tikv:masterfrom
pingyu:pick-v2-codec-fix
Oct 7, 2023
Merged

[to #763] Pick bug fixes of API v2 codec to master#769
iosmanthus merged 4 commits into
tikv:masterfrom
pingyu:pick-v2-codec-fix

Conversation

@pingyu

@pingyu pingyu commented Sep 24, 2023

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #763

Problem Description: decode EpochNotMatch should ignore invalid region

What is changed and how does it work?

Cherry pick from release-3.3.1.14:

Code changes

  • No.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

  • NO side effects

Related changes

  • NO related changes

iosmanthus and others added 3 commits September 24, 2023 16:19
…v#765)

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
* fix region decoding

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add test for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add more tests for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
* complement v2 codec unit test cases.

Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix fmt

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu changed the title [to #763] Pick v2 codec fix to master [to #763] Pick bug fixes of API v2 codec to master Sep 24, 2023
@codecov

codecov Bot commented Oct 7, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
.../org/tikv/common/apiversion/RequestKeyV2Codec.java 88.57% <100.00%> (+5.71%) ⬆️
...in/java/org/tikv/common/apiversion/CodecUtils.java 80.00% <0.00%> (ø)
.../org/tikv/common/operation/RegionErrorHandler.java 49.68% <40.00%> (-0.64%) ⬇️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pingyu pingyu requested a review from iosmanthus October 7, 2023 08:11
@iosmanthus iosmanthus merged commit 533dbc2 into tikv:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decode EpochNotMatch should ignore invalid region

2 participants