[to #763] Complement v2 codec unit test cases#768
Merged
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu
changed the title
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
sunxiaoguang
approved these changes
Sep 24, 2023
iosmanthus
approved these changes
Sep 24, 2023
pingyu
added a commit
to pingyu/client-java
that referenced
this pull request
Sep 24, 2023
iosmanthus
added a commit
that referenced
this pull request
Oct 7, 2023
* [cherry-pick] ignore invalid region while decoding EpochNotMatch (#765) Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: Ping Yu <yuping@pingcap.com> * fix region out of keyspace (#766) * fix region decoding Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * add test for decodeRegion Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * add more tests for decodeRegion Signed-off-by: iosmanthus <myosmanthustree@gmail.com> --------- Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: Ping Yu <yuping@pingcap.com> * [to #763] Complement v2 codec unit test cases (#768) * complement v2 codec unit test cases. Signed-off-by: Ping Yu <yuping@pingcap.com> * fix fmt Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: Ping Yu <yuping@pingcap.com> --------- Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: Ping Yu <yuping@pingcap.com> Co-authored-by: iosmanthus <dengliming@pingcap.com>
iosmanthus
pushed a commit
to iosmanthus/client-java
that referenced
this pull request
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #763
Problem Description: decode EpochNotMatch should ignore invalid region
What is changed and how does it work?
Complement v2 codec unit test cases for the scene that the region is out of keyspace.
Ref: #766
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes