Skip to content

fix region out of keyspace#766

Merged
iosmanthus merged 3 commits into
tikv:release-3.3.1.14from
iosmanthus:fix-region-out-of-keyspace
Sep 19, 2023
Merged

fix region out of keyspace#766
iosmanthus merged 3 commits into
tikv:release-3.3.1.14from
iosmanthus:fix-region-out-of-keyspace

Conversation

@iosmanthus

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #issue_number

Problem Description: TBD

What is changed and how does it work?

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov

codecov Bot commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

Patch has no changes to coverable lines.

❗ Current head bac34ee differs from pull request most recent head fff16be. Consider uploading reports for the commit fff16be to get more accurate results

📢 Thoughts on this report? Let us know!.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Comment thread src/test/java/org/tikv/common/apiversion/RequestKeyCodecTest.java
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

@pingyu pingyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@iosmanthus iosmanthus merged commit 37f9796 into tikv:release-3.3.1.14 Sep 19, 2023
@iosmanthus iosmanthus deleted the fix-region-out-of-keyspace branch September 19, 2023 05:15
pingyu pushed a commit to pingyu/client-java that referenced this pull request Sep 24, 2023
* fix region decoding

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add test for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add more tests for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
iosmanthus added a commit that referenced this pull request Oct 7, 2023
* [cherry-pick] ignore invalid region while decoding EpochNotMatch (#765)

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix region out of keyspace (#766)

* fix region decoding

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add test for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add more tests for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>

* [to #763] Complement v2 codec unit test cases (#768)

* complement v2 codec unit test cases.

Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix fmt

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Co-authored-by: iosmanthus <dengliming@pingcap.com>
iosmanthus added a commit to iosmanthus/client-java that referenced this pull request Oct 10, 2023
* fix region decoding

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add test for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add more tests for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants