Skip to content

[close #519] remove cdc and br releated components#563

Merged
zz-jason merged 2 commits into
tikv:masterfrom
marsishandsome:feature/remove-code
Mar 23, 2022
Merged

[close #519] remove cdc and br releated components#563
zz-jason merged 2 commits into
tikv:masterfrom
marsishandsome:feature/remove-code

Conversation

@marsishandsome

@marsishandsome marsishandsome commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

Issue Number: close #519

What is changed and how it works?

move irrelevant code out of client-java repo

Code changes

  • Has exported function/method change

@codecov

codecov Bot commented Mar 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #563 (03b466f) into master (e89ca5f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #563      +/-   ##
============================================
- Coverage     32.27%   32.26%   -0.02%     
+ Complexity     1340     1304      -36     
============================================
  Files           279      270       -9     
  Lines         17385    17054     -331     
  Branches       1981     1950      -31     
============================================
- Hits           5611     5502     -109     
+ Misses        11167    10953     -214     
+ Partials        607      599       -8     
Impacted Files Coverage Δ
src/main/java/io/grpc/netty/WriteQueue.java 74.43% <0.00%> (-13.54%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 46.45% <0.00%> (-5.14%) ⬇️
...va/org/tikv/common/region/StoreHealthyChecker.java 69.73% <0.00%> (-3.95%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.34% <0.00%> (-0.49%) ⬇️
src/main/java/org/tikv/common/PDClient.java 59.27% <0.00%> (-0.49%) ⬇️
src/main/java/org/tikv/common/TiSession.java 70.67% <0.00%> (-0.49%) ⬇️
...java/org/tikv/common/region/RegionStoreClient.java 47.85% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89ca5f...03b466f. Read the comment docs.

@marsishandsome

Copy link
Copy Markdown
Collaborator Author

@iosmanthus @zz-jason PTAL

zz-jason
zz-jason previously approved these changes Mar 23, 2022

@zz-jason zz-jason left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason enabled auto-merge (squash) March 23, 2022 02:57
@zz-jason

Copy link
Copy Markdown
Member

@marsishandsome could you also remove coprocessor-related files?

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome

Copy link
Copy Markdown
Collaborator Author

@marsishandsome could you also remove coprocessor-related files?

This work will be done in another PR.

@iosmanthus iosmanthus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 92fea32 into tikv:master Mar 23, 2022
@MengXiangDing

Copy link
Copy Markdown

Hi, where has the cdc component been moved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move irrelevant code out of client-java repo

5 participants