Skip to content

log SlowLog if error occures#361

Merged
zz-jason merged 1 commit into
tikv:masterfrom
marsishandsome:feature/improve-slowlog
Dec 6, 2021
Merged

log SlowLog if error occures#361
zz-jason merged 1 commit into
tikv:masterfrom
marsishandsome:feature/improve-slowlog

Conversation

@marsishandsome

@marsishandsome marsishandsome commented Dec 6, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

close #362

Currently TiKV will only log SlowLog if slowThresholdMS exceeds.

Besides TiKV should also log SlowLog if error occures.

@marsishandsome

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/improve-slowlog branch from 9009a2e to 5bfa543 Compare December 6, 2021 04:34
@marsishandsome

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@iosmanthus iosmanthus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome

Copy link
Copy Markdown
Collaborator Author

@birdstorm @zz-jason PTAL

@zz-jason zz-jason left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit f12d19d into tikv:master Dec 6, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot

Copy link
Copy Markdown
Collaborator

cherry pick to release-3.1 in PR #363

zz-jason pushed a commit that referenced this pull request Dec 6, 2021
ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log SlowLog if error occures

4 participants