Skip to content

refactor getRegionStoreClientBuilder to improve readability#349

Merged
ti-srebot merged 2 commits into
tikv:masterfrom
zz-jason:refactor/getRegionStoreClientBuilder
Nov 29, 2021
Merged

refactor getRegionStoreClientBuilder to improve readability#349
ti-srebot merged 2 commits into
tikv:masterfrom
zz-jason:refactor/getRegionStoreClientBuilder

Conversation

@zz-jason

Copy link
Copy Markdown
Member

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

improve readability

What is changed and how it works?

  1. refactor getRegionStoreClientBuilder to reduce code indent
  2. try to use getRegionStoreClientBuilder to create RawKVClient and KVClient

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

@marsishandsome marsishandsome left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason

Copy link
Copy Markdown
Member Author

/merge

@ti-srebot

Copy link
Copy Markdown
Collaborator

Your auto merge job has been accepted, waiting for:

  • 347

@ti-srebot

Copy link
Copy Markdown
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit c642d3e into tikv:master Nov 29, 2021
@zz-jason zz-jason deleted the refactor/getRegionStoreClientBuilder branch November 29, 2021 10:52
ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants