Skip to content

Support configuration property file#295

Merged
marsishandsome merged 1 commit into
tikv:masterfrom
marsishandsome:feature/conf-file
Oct 27, 2021
Merged

Support configuration property file#295
marsishandsome merged 1 commit into
tikv:masterfrom
marsishandsome:feature/conf-file

Conversation

@marsishandsome

@marsishandsome marsishandsome commented Oct 27, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

Support configuration property file

What is changed and how it works?

add parameter tikv.config_file

  • tikv java client config file
  • default: null

This parameter can be passed by -Dtikv.config_file=/path/to/tikv_client_config.properties.

Here is an example of tikv_client_config.properties.

tikv.grpc.timeout_in_ms=150ms 
tikv.grpc.forward_timeout_in_ms=200ms
tikv.metrics.enable=true
tikv.metrics.port=3140

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@Little-Wallace Little-Wallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/main/java/org/tikv/common/ConfigUtils.java
Comment thread src/main/java/org/tikv/common/TiConfiguration.java

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented

@marsishandsome marsishandsome merged commit 11bd222 into tikv:master Oct 27, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Oct 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot

Copy link
Copy Markdown
Collaborator

cherry pick to release-3.1 in PR #296

marsishandsome added a commit that referenced this pull request Oct 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants