Skip to content

Support select replica with rich meta data (#171)#225

Merged
birdstorm merged 2 commits into
tikv:release-3.1from
ti-srebot:release-3.1-fe6617e3c067
Jun 30, 2021
Merged

Support select replica with rich meta data (#171)#225
birdstorm merged 2 commits into
tikv:release-3.1from
ti-srebot:release-3.1-fe6617e3c067

Conversation

@ti-srebot

@ti-srebot ti-srebot commented Jun 30, 2021

Copy link
Copy Markdown
Collaborator

cherry-pick #171 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/225

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/225:release-3.1-fe6617e3c067

Signed-off-by: Xiaoguang Sun sunxiaoguang@zhihu.com

What problem does this PR solve?

Pass in more meta data so ReplicaSelector can make better decision at runtime

What is changed and how it works?

Pass in more meta data so ReplicaSelector can make better decision at runtime

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

birdstorm
birdstorm previously approved these changes Jun 30, 2021

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm

Copy link
Copy Markdown
Collaborator

/merge

@ti-srebot

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@ti-srebot

Copy link
Copy Markdown
Collaborator Author

@ti-srebot merge failed.

@birdstorm

Copy link
Copy Markdown
Collaborator

/merge

@ti-srebot

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@ti-srebot

Copy link
Copy Markdown
Collaborator Author

@ti-srebot merge failed.

Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm

Copy link
Copy Markdown
Collaborator

/merge

@ti-srebot

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit e02e61c into tikv:release-3.1 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants