lottie/expressions: support posterizeTime#4182
Conversation
tinyjin
force-pushed
the
jinny/exp-posterize-time
branch
2 times, most recently
from
d2736ce to
686f7c1
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for the After Effects expression function posterizeTime(fps) to the Lottie expressions runtime, allowing time/value quantization to FPS intervals during expression evaluation.
Changes:
- Introduces a
posterizeTimefunction binding in the global expression realm. - Implements
_posterizeTime()to quantizetimeand updatevalueaccordingly. - Wires the function into evaluation by attaching the current
LottieExpression*as native data and releasing the new JerryScript value in the destructor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/loaders/lottie/tvgLottieExpressions.h |
Adds posterizeTime handle to the LottieExpressions runtime state. |
src/loaders/lottie/tvgLottieExpressions.cpp |
Implements and registers posterizeTime, and wires native pointer setup + cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tinyjin
force-pushed
the
jinny/exp-posterize-time
branch
2 times, most recently
from
f560bb3 to
e9d1a0c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tinyjin Let's apply this once we have a practical real-world usage. Thanks. |
hermet
force-pushed
the
main
branch
2 times, most recently
from
5cb1306 to
f076d22
Compare
tinyjin
force-pushed
the
jinny/exp-posterize-time
branch
from
e9d1a0c to
10f8d52
Compare
hermet
force-pushed
the
main
branch
2 times, most recently
from
a00fdaa to
9bd7217
Compare
tinyjin
force-pushed
the
jinny/exp-posterize-time
branch
from
10f8d52 to
d0fb1cf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Overview
Test file: posterizeTime(3).json
See also: https://lottiefiles.github.io/lottie-docs/expressions/#posterizetime
More Examples