use more appropriate names now that the additional move effect can be used for different purposes

Thomas Maeder · Thomas Maeder · commit 1b4f8c5eca8c · 2025-11-28T17:12:46.000+01:00
diff --git a/pieces/attributes/total_invisible.c b/pieces/attributes/total_invisible.c
@@ -909,7 +909,7 @@ void total_invisible_move_sequence_tester_solve(slice_index si)
  *            n+3 no solution found in next branch
  *            (with n denominating solve_nr_remaining)
  */
-void total_invisible_reserve_king_movement(slice_index si)
+void total_invisible_reserve_additional_effect(slice_index si)
 {
   move_effect_journal_index_type const base = move_effect_journal_base[nbply];
   move_effect_journal_index_type const capture = base+move_effect_journal_index_offset_capture;
@@ -928,7 +928,7 @@ void total_invisible_reserve_king_movement(slice_index si)
   else
   {
     /* reserve a spot in the move effect journal for the case that a move by an invisible
-     * turns out to move a side's king square
+     * turns out to move a side's king square or a pawn promotion
      */
     move_effect_journal_do_null_effect(move_effect_no_reason);
     pipe_solve_delegate(si);
@@ -1258,10 +1258,10 @@ static void copy_help_branch(slice_index si,
       slice_index const prototypes[] = {
           alloc_pipe(STTotalInvisibleMovesByInvisibleGenerator),
           alloc_pipe(STTotalInvisibleSpecialMovesPlayer),
-          alloc_pipe(STTotalInvisibleReserveKingMovement),
+          alloc_pipe(STTotalInvisibleReserveAdditionalEffect),
           alloc_pipe(STTotalInvisibleMovesByInvisibleGenerator),
           alloc_pipe(STTotalInvisibleSpecialMovesPlayer),
-          alloc_pipe(STTotalInvisibleReserveKingMovement)
+          alloc_pipe(STTotalInvisibleReserveAdditionalEffect)
       };
       enum { nr_protypes = sizeof prototypes / sizeof prototypes[0] };
       slice_insertion_insert(si,prototypes,nr_protypes);
diff --git a/pieces/attributes/total_invisible.h b/pieces/attributes/total_invisible.h
@@ -67,7 +67,7 @@ void total_invisible_invisibles_allocator_solve(slice_index si);
  *            n+3 no solution found in next branch
  *            (with n denominating solve_nr_remaining)
  */
-void total_invisible_reserve_king_movement(slice_index si);
+void total_invisible_reserve_additional_effect(slice_index si);
 
 /* Instrument the solvers with support for Total Invisible pieces
  * @param si identifies the root slice of the stipulation
diff --git a/solving/machinery/dispatch.c b/solving/machinery/dispatch.c
@@ -2276,8 +2276,8 @@ void dispatch(slice_index si)
       total_invisible_special_moves_player_solve(si);
       break;
 
-    case STTotalInvisibleReserveKingMovement:
-      total_invisible_reserve_king_movement(si);
+    case STTotalInvisibleReserveAdditionalEffect:
+      total_invisible_reserve_additional_effect(si);
       break;
 
     case STTotalInvisibleMovesByInvisibleGenerator:
diff --git a/stipulation/move.c b/stipulation/move.c
@@ -123,7 +123,7 @@ static slice_index const move_slice_rank_order[] =
     STLostPiecesRemover,
     STLandingAfterMovePlay,
     STMoveCounter,
-    STTotalInvisibleReserveKingMovement,
+    STTotalInvisibleReserveAdditionalEffect,
     STKingSquareUpdater,
     STBGLAdjuster,
     STKoekoLegalityTester,
diff --git a/stipulation/slice_type.enum b/stipulation/slice_type.enum
@@ -636,7 +636,7 @@
     ENUMERATOR(STTotalInvisibleSpecialMoveGenerator),                   \
     ENUMERATOR(STTotalInvisibleMovesByInvisibleGenerator),              \
     ENUMERATOR(STTotalInvisibleSpecialMovesPlayer),                     \
-    ENUMERATOR(STTotalInvisibleReserveKingMovement),                    \
+    ENUMERATOR(STTotalInvisibleReserveAdditionalEffect),                \
     ENUMERATOR(STTotalInvisibleRevealAfterFinalMove),                   \
     /* output slices */                                                 \
     ENUMERATOR(STOutputModeSelector), /* select an output mode for the subsequent play */ \
diff --git a/stipulation/slice_type.enum.h b/stipulation/slice_type.enum.h
