Skip to content

Conversation

@kumaryash90
Copy link
Member

Remove msg.sender. Take _defaultAdmin as input to constructor.

@nkrishang nkrishang enabled auto-merge (squash) October 26, 2023 16:34
@nkrishang nkrishang disabled auto-merge October 26, 2023 16:42
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...rebuilts/account/dynamic/DynamicAccountFactory.sol 50.00% <ø> (+50.00%) ⬆️
...rebuilts/account/managed/ManagedAccountFactory.sol 66.66% <ø> (ø)
...ebuilts/account/non-upgradeable/AccountFactory.sol 50.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@kumaryash90 kumaryash90 merged commit cb0f1da into main Oct 26, 2023
@kumaryash90 kumaryash90 deleted the yash/accountfactory-constructor-params branch October 26, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants