Skip to content

Revert "Minor tutorial related tweaks made after reviewing PR #775"#962

Merged
lukpueh merged 1 commit into
developfrom
revert-961-joshuagl/tutorial
Nov 29, 2019
Merged

Revert "Minor tutorial related tweaks made after reviewing PR #775"#962
lukpueh merged 1 commit into
developfrom
revert-961-joshuagl/tutorial

Conversation

@lukpueh

@lukpueh lukpueh commented Nov 29, 2019

Copy link
Copy Markdown
Member

Reverts #961

@joshuagl joshuagl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- line-wraps are integrated with
190a736 in #775
- sorting the value returned by `get_dirty_roles()` in
`dirty_roles()` is not necessary as `get_dirty_roles()` already
returns a sorted list per ac01033
in #775.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh force-pushed the revert-961-joshuagl/tutorial branch from 99ac934 to c5dac31 Compare November 29, 2019 11:35
@lukpueh lukpueh merged commit 409eef1 into develop Nov 29, 2019
@trishankatdatadog trishankatdatadog deleted the revert-961-joshuagl/tutorial branch October 13, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants